Eusth / HoneySelectVR

MIT License
109 stars 28 forks source link

voices are not working correctly in vr mode with new dlc #54

Open theboobness opened 7 years ago

theboobness commented 7 years ago

Hi Eusth, the voices aren't working correctly when I go in an H scene. there would be multiple voices (4 or more) playing at the same time. In normal mode without vr, the game plays fine. Is there any way to fix this?

Eusth commented 7 years ago

Completely untested, but try this: HoneySelectVR_0.6.1.zip

theboobness commented 7 years ago

Thank you!! it works perfectly now!!

plasticfant commented 7 years ago

I posted this to the honeyselect subreddit so more VR users can test. https://www.reddit.com/r/HoneySelect/comments/6930pt/anyone_able_to_get_vr_working_with_the_party_dlc/

As always, thank you Eusth for your huge contribution to VR

deinlandel commented 7 years ago

@Eusth Could you please tell what did you patched? I use custom HoneySelect plugin built from sources, and it seems that these changes are not published on Github...

Eusth commented 7 years ago

Yup, because it breaks the positional audio. Not gonna add the "fix" to the code. Simply remove the VoiceShim line in HoneySelectVR.cs.

Devilsbane99 commented 7 years ago

Thank you so much for this Eusth! Working great!

ice36bc commented 7 years ago

Thanks this the sound is working right now.

gzhuji commented 7 years ago

Thanks for update = v =

plasmacut commented 6 years ago

Does that mean there is no working positional audio for 1.20? Also my folder does not contain a HoneySelect.cs file. When using VR patch 0.6 there is also no positional audio unless it's used on version 1.1 for me.

ZerothAngel commented 5 years ago

The reason positional audio doesn't work in 1.20 is because a new bool force2D parameter was added to the Play and OnecePlayChara methods in Manager.Voice. For whatever reason, OnecePlayChara is called with this set to true during H-scenes.

I managed to fix this in a quick & dirty way (see my fork), but:

  1. I decided to use Harmony for runtime patching (just to learn it).
  2. I always set force2D to false.
DragonQuestHero commented 3 years ago

nice work!