search

EvEmu-Project / evemu_Crucible

Emulator for EvE Online's Crucible expansion
https://evemu.dev
174 stars 68 forks source link

updates from various authors #148

Closed zhyrohaad closed 2 years ago

Almamu commented 2 years ago

I'm trying to comment this directly on the sessionID/clientID changes, but github won't let me for some reason...

sessionID is not really acknowledged by the client at all, so it doesn't matter if we have it in the session. About clientID, I had already written a small commit to fix this and keep the clientID data in the session, because it might be useful in the future: 1364f2e54989386d5b3e6ca5cea2c4a36d2e89f9

It doesn't really matter which one we use tho.

zhyrohaad commented 2 years ago

ive kept the original data on how we get/set the sessionID and clientID in case we want to use it again at a later date.
i didnt see you're commit on the clientID, which is why i added it to mine. :) we can revisit this later if there is a need to do so.