search

EvEmu-Project / evemu_Crucible

Emulator for EvE Online's Crucible expansion
https://evemu.dev
174 stars 68 forks source link

Fix for #173 (SIGSEGV on destroying a target) #175

Closed SantjagoCorkez closed 2 years ago

VizanArkonin commented 2 years ago

@SantjagoCorkez Hi mate! Ty for a pull request. May we ask you to re-route it towards staging branch? We use staging branch to accumulate current development changes. Once the code state is stabilized, it is merged in master.

SantjagoCorkez commented 2 years ago

Seems already handled another way in staging. Up to you to decide which implementation to use

VizanArkonin commented 2 years ago

@jdhirst any thoughts?

jdhirst commented 2 years ago

@VizanArkonin @SantjagoCorkez TargetManager is currently being rewritten in Staging, so if we are sure that the issue does not reappear in that codebase, I suggest continuing with that implementation.

VizanArkonin commented 2 years ago

Let's keep the current implementation then. @SantjagoCorkez Nevertheless, thanks a ton for a pull request!