search

EvEmu-Project / evemu_Crucible

Emulator for EvE Online's Crucible expansion
https://evemu.dev
170 stars 66 forks source link

jetcan not exploding when emptyed #196

Closed idolord closed 2 years ago

idolord commented 2 years ago

Describe the bug jetcan stay in space enven when the content is emptyed

To Reproduce Steps to reproduce the behavior:

  1. Go to anywhere
  2. jettison an item
  3. grabb it in your cargohold
  4. See je jettison happily saying even if empty

Expected behavior jetcan should self destruct if emptied.

Screenshots image

jdhirst commented 2 years ago

That should be a simple check which can be added to the ContainerSE class. It can automatically destroy itself if it sees no cargo inside itself. I can't think of a better place to add it; @Almamu your thoughts?

It would be important that this check ONLY apply to Jetcans, not other containers, so a typeID check would need to be in place as well.

idolord commented 2 years ago

fixed with https://github.com/EvEmu-Project/evemu_Crucible/pull/198

jdhirst commented 2 years ago

Closing as fixed