search

EvEmu-Project / evemu_Crucible

Emulator for EvE Online's Crucible expansion
https://evemu.dev
170 stars 66 forks source link

fixing both tractor beam and persistant jetcan #198

Closed idolord closed 2 years ago

idolord commented 2 years ago

ShipService : after populating the jetcan with items set it to unachored. Container : implemented swich case to determine if container should be destroyer whene empty.

Almamu commented 2 years ago

Can one of the admins verify this patch?

jdhirst commented 2 years ago

!oktotest

jdhirst commented 2 years ago

I really like the simple implementation here, should do exactly what we need it to do to fix #196

Since it just calls Delete(), I suspect no explosion animation/effect is played. Is this the case @idolord?

idolord commented 2 years ago

No, no animation yet I might have to dig a bit more to get the method I need to call to make it literaly "explode". If anyone have a clue ...

jdhirst commented 2 years ago

I checked around for a bit but couldn't find something trivial, it'll likely require a new item in DestinyManager to send the effect. As such, lets just merge this for now and that addition can come in another PR

jdhirst commented 2 years ago

@idolord oh wait, I just realized this is going into master, can you please rebase this on staging instead? We want to keep all code additions for staging alone and only merge to master when a substantial amount of changes are ready to go

idolord commented 2 years ago

I will but won't be able to before 19h GMT... Le mer. 23 mars 2022 à 11:35, James Hirst @.***> a écrit :

@idolord https://github.com/idolord oh wait, I just realized this is going into master, can you please rebase this on staging instead? We want to keep all code additions for staging alone and only merge to master when a substantial amount of changes are ready to go

— Reply to this email directly, view it on GitHub https://github.com/EvEmu-Project/evemu_Crucible/pull/198#issuecomment-1076209886, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHNQLFCHU5B4QTLHKG723LVBLXWLANCNFSM5RMFKO5Q . You are receiving this because you were mentioned.Message ID: @.***>

jdhirst commented 2 years ago

Closing as obseleted by #201