search

EvEmu-Project / evemu_Crucible

Emulator for EvE Online's Crucible expansion
https://evemu.dev
170 stars 66 forks source link

Change ContainerSE to derive from StructureSE #207

Closed idolord closed 2 years ago

idolord commented 2 years ago

switched CargoContainer and ContainerSE inheritance to structureItem and StructureSE respectively. should slove the cargo weird behaviours (not loading) ...

Almamu commented 2 years ago

The change looks promising @jdhirst anything that might need some extra comments? Unless you have any extra comments, just answering the questions i did under the review should be enough ;)

jdhirst commented 2 years ago

@Almamu you posted comments in this PR? I don't see them

jdhirst commented 2 years ago

!oktotest

Almamu commented 2 years ago

I started a review, you might need to expand it to see my comments.

idolord commented 2 years ago

I can't see your review either ... saw it on discord tho ... fist point ... yeah unnecessary reverting on next pull second point you'r right this case shouldn't log anything or warn of the, to be implemented, 2d timer. (which won't comme next pull but in the future, meaning after I tie cargo anchoring back to the structur anchoring and fix the jettisoning of cargo)

Almamu commented 2 years ago

Sorry about the review thing, forgot to click the button to actually publish it -.-'

jdhirst commented 2 years ago

Looks good to merge, great work @idolord !