EvEmu-Project / evemu_Crucible

Emulator for EvE Online's Crucible expansion
https://evemu.dev
170 stars 66 forks source link

Format strings using %li/%lu in Windows are broken #232

Closed Almamu closed 1 year ago

Almamu commented 1 year ago

Describe the bug Due to being Linux-exclusive after the merge with Allan's codebase we haven't supported Windows, but with the last changes on the staging branch we're now compatible with Windows again. While doing some testing, this has highlighted one important issue. Every 64 bits data type that we save to the database is formated with %li, which works fine on Linux, but doesn't work on Windows. All these format parameters should be updated (and tested whenever feasible and possible) to use the right formatting %lli/%llu, as shown in #229

Almamu commented 1 year ago

This should have been fixed in #236