search

EvEmu-Project / evemu_Crucible

Emulator for EvE Online's Crucible expansion
https://evemu.dev
168 stars 65 forks source link

Fix for security status in character sheet not working #277

Closed d10sfan closed 10 months ago

d10sfan commented 10 months ago

Fixes https://github.com/EvEmu-Project/evemu_Crucible/issues/271

The last three arguments in the call from the character sheet are the issue, so adding std::optional looks to fix it. Since the method body does not use these parameters, it seemed safe to do, from looking at other code in this project.

I was able to successfully use these changes to open the character sheet and look at my standing & security status, along with being able to access the standing tab on the view info section of my character (the window that appears when you click on your portrait or another character's portrait), just to make sure that that still worked as expected.

jdhirst commented 10 months ago

Looks good to me, thanks for your contribution!