search

EvEmu-Project / evemu_Crucible

Emulator for EvE Online's Crucible expansion
https://evemu.dev
174 stars 68 forks source link

Fixes for character contacts #280

Closed d10sfan closed 1 year ago

d10sfan commented 1 year ago

The first commit fixes the function signatures for AddContact and EditContact, so that they work (DeleteContact was already correct). I wasn't sure if the original ones still made sense, so I kept them, but they could be replaced instead.

The second commit fixes an issue with the return of GetContacts, without this change I was getting an error once I had a contact on my character. Once I changed the return to DBResultToCRowset, it started working, and I could see my contacts list.

With these changes, I'm able to see my contact list, add a contact, logout & log back in and see the contact persist, edit a contact, and delete a contact.

jdhirst commented 1 year ago

Looks good to me, thanks as always!