search

EvEmu-Project / evemu_Crucible

Emulator for EvE Online's Crucible expansion
https://evemu.dev
174 stars 68 forks source link

Docking up while being target painted causes a segfault #39

Open jdhirst opened 3 years ago

jdhirst commented 3 years ago

From AlasiyaEvE created by ryllae: zhyrohaad/AlasiyaEvE#108

Equip a fleet republic target painter, activate on a player character in high sec. Have the other toon dock up. SEGFAULT.

jdhirst commented 3 years ago

Rats could be shooting you while warping or session changing, so I assume you'd have the same problem there either way. It's just easier for me to test docking.

jdhirst commented 3 years ago

target manager has been updated, and seems to be working correctly from my testing. update pushed to main server.

jdhirst commented 3 years ago

Nope. I undocked a Hawk and a Noctis. Had the Hawk target paint the Noctis. Crashes when the Noctis docks.

jdhirst commented 3 years ago

that tells me that module code thats supposed to be doing "ship status" updates (jump, dock, warp, etc) are NOT processing correctly. i'll look into this tonite.

edit it's ANY module activated on a docking ship, not just painters edit again and its not just docking. my status update processor was faulty and incomplete. did some more work to it. test again and report when ya get time, pls.

jdhirst commented 3 years ago

must be something funny on main server, as i cannot reproduce this on dev

jdhirst commented 3 years ago

Still crashes.

jdhirst commented 3 years ago

I think your latest comment confirmed this, but it's still broken.

jdhirst commented 3 years ago

Working correctly on dev eb777b.

jdhirst commented 3 years ago

This has been updated and should work for all possible scenarios

EDIT - UPDATE after digging into this a bit more, i have found TargetManager code is old, outdated, and about half of it's responses to client are being ignored, as it was written for the Apoc version. am currently rewriting functions and methods, and updating responses.

jdhirst commented 3 years ago

touch

jdhirst commented 3 years ago

Not really. TargMgr is separate system. However, never expected rats targeting while docking, so never tested that scenario.

jdhirst commented 3 years ago

main server updated

jdhirst commented 3 years ago

Haven't tested target painting, but rats acquiring a lock while docking segfaults. https://github.com/zhyrohaad/AlasiyaEvE/issues/75 Related?

jdhirst commented 3 years ago

I hadn't thought of it, but you're right. However it's not coded that way, in contrast to my generic module "target destroyed" call. The dock, jump,warp, etc, is specific, but should not be. This highlights a shortcoming in the code and need to be addressed. This and the referenced module code are top priority.

jdhirst commented 3 years ago

Still crashes.

zhyrohaad commented 2 years ago

has this been looked at or tested since merge to official branch? prefer testing on staging, as that code has more fixes (but possibly has more errors)