search

EvHaus / doby-grid

An HTML table element on steroids.
Other
14 stars 5 forks source link

Prevent remoteFetch during horizontal scroll #167

Closed mminer closed 9 years ago

mminer commented 9 years ago

There's no mechanism to fetch more columns, so it makes little sense to trigger remote fetches when horizontally scrolling. To prevent this I changed the viewportchanged event to include the vertical and horizontal scroll distance. Only when the vertical scroll distance is greater than zero do we call remoteFetch. This should fix #122.

mminer commented 9 years ago

Oops, looks like I broke a unit test. I'll get this fixed.

EvHaus commented 9 years ago

Let's rename vScrollDist to scrollTopDelta and hScrollDist to scrollLeftDelta. I've updated the docs accordingly: http://dobyjs.com/#grid-events-scroll