EvHaus / doby-grid

An HTML table element on steroids.
Other
14 stars 5 forks source link

Further jquery node fixes. Remove method cleans up listeners too. #195

Closed AlanUnderwood closed 8 years ago

AlanUnderwood commented 8 years ago

I had a problem with the calls to append newly rendered content to cells that hadn't rendered into the cache. I fixed it by changing the call to use jQuery calls rather than DOM methods. I think the benefits of this over the one in #194 are:

Please note, I find the unit tests fail on my Ubuntu laptop, but it is on the estimate of how wide the fonts are, so I hope on your build systems they will work. All other tests pass.

   options.minColumnWidth
     - should be enabled empty by default......✓
     - should resize columns to match the header content width when using 'headerContent'......X
       Expected 244 to be greater than 247. (1)
       Expected 223 to be greater than 247. (2)
     - should be able to toggle the 'minColumnWidth' property using 'setOptions'......X
       Expected 244 to be greater than 247. (1)
       Expected 223 to be greater than 247. (2)