search

EvHaus / doby-grid

An HTML table element on steroids.
Other
14 stars 5 forks source link

Fixes for large remote data #197

Closed AlanUnderwood closed 8 years ago

AlanUnderwood commented 8 years ago

The first commit fixes an issue where data with many columns, some of which are not rendered, throws an error on selection because there is no jQuery node to work with.

The second commit allows you to use the onLoading and onLoaded functions when doing a remote count call. These can take a not-insignificant amount of time to run with large remote data sets, so it gives you the chance to inform the user that 'something is happening'.

The last commit fixes an issues where you create the grid, restore state and then append, with remote data, which fires unnecessary extra remote fetches.

EvHaus commented 8 years ago

Thanks. I'll try to get this reviewed soon. However, can you please remove the updates to the /build/ files? We'll issue new build files after a new release is ready.

AlanUnderwood commented 8 years ago

Okay. I'll try to get round to that tomorrow evening. Cheers On 23 Dec 2015 01:50, "Evgueni Naverniouk" notifications@github.com wrote:

Thanks. I'll try to get this reviewed soon. However, can you please remove the updates to the /build/ files? We'll issue new build files after a new release is ready.

— Reply to this email directly or view it on GitHub https://github.com/globexdesigns/doby-grid/pull/197#issuecomment-166776744 .

AlanUnderwood commented 8 years ago

Okay. I've force-pushed changes to my master branch removing the build/ files. Please review

EvHaus commented 8 years ago

This has landed in 0.1.3