search

EvaMaeRey / xaringanPrinter

convert xaringan/remark.js slides to Xaringan
Other
7 stars 1 forks source link

Copying mp4 output code to xaringanBuilder #4

Open jhelvy opened 3 years ago

jhelvy commented 3 years ago

Hi! Seeing that @brshallo already incorporated the pptx output in xaringanBuilder, would you be okay with me adding the mp4 output as well? I was going to modify the code you have in this package to add support for video outputs. @EvaMaeRey I'll add you as a contributor if you'd like.

EvaMaeRey commented 3 years ago

I never got the mp4 output working unfortunately. Still curious about that. One thing I ran into was images and text becoming washed out when converting to pdf (and so also gif). Is it something you noticed? Any fix? I'd be interested following up there if not.

EvaMaeRey commented 3 years ago

Motivation for mp4 was that sharing gifs via twitter wasn't reliable. Upload would usually fail.

jhelvy commented 3 years ago

I never got the mp4 output working unfortunately. Still curious about that. One thing I ran into was images and text becoming washed out when converting to pdf (and so also gif). Is it something you noticed? Any fix? I'd be interested following up there if not.

I'm not having these issues when converting to pdf and gif. Perhaps it's because after making the pdf files your code combines them with pdftools::pdf_combine()? I just use pagedown::chrome_print() to print the whole slide deck and it seems to work.

jhelvy commented 3 years ago

Okay, I added an issue to see if I can't figure out a way to make a video output work.

jhelvy commented 3 years ago

Alright, I have what looks like a working solution with v0.0.7 of xaringanBuilder. I would be grateful if you tried it out to see if it works for others - I've only done very crude testing.