search

EvaTheDM / mildly-magical-inspiration

This module lets Gamemasters create card decks and hand those cards out to their players. It can be used as an alternative way to handout inspiration to players in D&D 5th Edition.
MIT License
1 stars 1 forks source link

[BUG] Giving choices to multiple players breaks the module #19

Closed FI-Aquacrest closed 3 years ago

FI-Aquacrest commented 3 years ago

Describe the bug Awarding a choice for an inspiration card for multiple players seems to break the system.

To Reproduce Steps to reproduce the behavior:

  1. Be in a session as GM with at least 2 online players
  2. Set the "random size" -setting to >1
  3. Award a card to a player
  4. Award a card to another player while the previous player has not yet made their choice
  5. Second player will not see a choice but they still count as having a card
  6. If a player with an "invisible" (step 4) card tries to use one, the "used" notification will loop forever

Expected behavior Multiple people should be able to choose their cards simultaneously OR the GM should be blocked from giving new cards before a decision is made. As a side issue, recalling the cards does not close the card choice dialogue, meaning a player can choose and receive a card even though the cards have been recalled.

Desktop:

Additional context I am using other modules and have not yet had the chance to try this module on its own, but this feels like an issue with the mod rather than a conflict.

EvaTheDM commented 3 years ago

Thank you for the indepth description on how to repoduce the error. I have found what has been causing it and an update has been released!