search

EvanAgee / vuejs-wordpress-theme-starter

A WordPress theme with the guts ripped out and replaced with Vue.
https://vuewp.com/
1.6k stars 282 forks source link

Add tailwindcss and update packages #66

Closed Tes3awy closed 4 years ago

Tes3awy commented 4 years ago

Breaking changes

1- Add tailwindcss as the CSS framework. 2- Add tailwind.config.js file and updated postcss.config.js. 3- Add tailwind preflight to _tailwind.css and link within styles.css, 4- Update packages considering they are working perfectly. 5- Update the .gitignore file and deleted lock files. 6- Extract scss/sass into a separate test.

EvanAgee commented 4 years ago

Very nice work @Tes3awy! Definitely super useful but I'm not entirely sure that I want to commit to any specific CSS framework for this project since the idea is for it to be as un-opinionated as possible. Let me think about it for a bit and figure out a good way to make this available to others without it being in master. I'll definitely make use of it myself though, thanks!

Tes3awy commented 4 years ago

Sure @EvanAgee. I just want to explain my point of view in adding tailwindcss to the projects. Tailwind is a utility-first CSS framework. It's not like bootstrap or vuetify. It doesn't use components or directives. It's just pure CSS classes. Also, it includes its media queries and that staff you already defined in the styles.css file. I'd like you to have a look at this page. The title says Most CSS frameworks do too much. So it's probably unopinionated and should be okay with the project. Thank you @EvanAgee for this amazing work :)

EvanAgee commented 4 years ago

@Tes3awy Oh I'm a big fan of Tailwind, no doubt about it! I'm leaning more and more towards merging this since no one HAS to use it if they don't want to.

EvanAgee commented 4 years ago

@Tes3awy as part of this PR would you also update the README to include note(s) about the Tailwind integration?

Tes3awy commented 4 years ago

@EvanAgee of course, I'll. I am just waiting for the pull-request to get accepted and then after update the Readme file.

Tes3awy commented 4 years ago

Hello @EvanAgee, I updated the README.md file to include some references for the newly added features.

EvanAgee commented 4 years ago

Thanks for all of your work on this, I'm about to release an update that includes Tailwind!