search

EvanDotPro / EdpSuperluminal

This module caches the common Zend\* classes used by your application into a single cache file, reducing reliance on the autoloader. This greatly improves the performance of ZF2.
BSD 2-Clause "Simplified" License
170 stars 47 forks source link

Refactor out some classes + add test coverage #33

Closed lsklyut closed 2 years ago

lsklyut commented 9 years ago

I've taken most of the logic that was in Module.php and moved it to classes with some tests. I'm hoping that we can use this as a base to extract a utility for use in other frameworks - I think this concept could benefit Symfony and others just as much as ZF2 (maybe?). I've done a test run on PHP 5.4 (ZF-Skeleton) and confirmed that the cache produced by the master branch is equivalent to the one produced by this pull request. Any further testing + feedback appreciated!

cache-result

lsklyut commented 9 years ago

I've also included included @lvismer 's issue here as part of the PR (Skipping classes with an Annotation tag)

snapshotpl commented 9 years ago

I like this changes. What are think @EvanDotPro ?

seyfer commented 9 years ago

:+1: it should be merged!

https://github.com/EvanDotPro/EdpSuperluminal/issues/34

seyfer commented 9 years ago

Here is a problem..

Fatal error: Uncaught exception 'Zend\ServiceManager\Exception\ServiceNotCreatedException' with message 'While attempting to create edpsuperluminalcachebuilder(alias: EdpSuperluminal\CacheBuilder) an invalid factory was registered for this instance type.'