search

EvanHahn / HumanizeDuration.js

361000 becomes "6 minutes, 1 second"
https://evanhahn.github.io/HumanizeDuration.js/
The Unlicense
1.65k stars 175 forks source link

This module is in maintenance mode #120

Closed EvanHahn closed 6 years ago

EvanHahn commented 7 years ago

I no longer have time to add new features to this module, unfortunately.

If you're interested in taking over the project, please leave an issue here and we can discuss! You can also send an email to me@evanhahn.com if you'd prefer.

DiegoZoracKy commented 7 years ago

Will you still accept and merge PRs?

EvanHahn commented 7 years ago

@DiegoZoracKy Yes for bugfixes and small changes; no for large features.

DiegoZoracKy commented 7 years ago

I was thinking about trying to get the language from navigator.language, and set it as the default language. Is this the kind of features that you wouldn't be accepting?

On Jun 29, 2017 1:53 PM, "Evan Hahn" notifications@github.com wrote:

@DiegoZoracKy https://github.com/diegozoracky Yes for bugfixes and small changes; no for large features.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EvanHahn/HumanizeDuration.js/issues/120#issuecomment-312027088, or mute the thread https://github.com/notifications/unsubscribe-auth/AB_oP_5zMyxjDTN8mGkIBxwNUQQAafIKks5sI9Z8gaJpZM4Nj0jI .

EvanHahn commented 7 years ago

I don't want this library to depend on the browser, so I don't think I'd accept that change. Happy to add something to the readme to show how to do that, though!

DiegoZoracKy commented 7 years ago

Yes, I also thought about. We could also try to get the locale from OS when running on Node.js.

On Jun 29, 2017 2:07 PM, "Evan Hahn" notifications@github.com wrote:

I don't want this library to depend on the browser, so I don't think I'd accept that change. Happy to add something to the readme to show how to do that, though!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EvanHahn/HumanizeDuration.js/issues/120#issuecomment-312030858, or mute the thread https://github.com/notifications/unsubscribe-auth/AB_oPzATqJ2Cbc_2czf00wzEGsek3u64ks5sI9nMgaJpZM4Nj0jI .

EvanHahn commented 7 years ago

Could you create a new issue so we can move discussion there?

DiegoZoracKy commented 7 years ago

Done! #122

On Jun 29, 2017 2:22 PM, "Evan Hahn" notifications@github.com wrote:

Could you create a new issue so we can move discussion there?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/EvanHahn/HumanizeDuration.js/issues/120#issuecomment-312034743, or mute the thread https://github.com/notifications/unsubscribe-auth/AB_oP3tGfXr4DLP9ehgyrbHSfkjo-7L8ks5sI91PgaJpZM4Nj0jI .

EvanHahn commented 6 years ago

Closing this issue—I'll maintain it but not add new features.