search

EvanHahn / HumanizeDuration.js

361000 becomes "6 minutes, 1 second"
https://evanhahn.github.io/HumanizeDuration.js/
The Unlicense
1.65k stars 175 forks source link

Arabic Localization Fix "minutes" #142

Closed 2bezzat closed 6 years ago

2bezzat commented 6 years ago

In Arabic language we have more than one condition to show "دقيقة" (minute) or "دقائق" (minutes) this pull request fixes that issue according to Arabic grammar and rules.

2bezzat commented 6 years ago

please notice that the test failed as it expects to return '2 دقائق' however the right value to be shown is 'دقيقتين'

EvanHahn commented 6 years ago

Could you also change the tests to make them pass?

2bezzat commented 6 years ago

@EvanHahn yeah sure, you can see now that the test passes and I've edited the test cases result

EvanHahn commented 6 years ago

Thanks! I am a bit busy right now but will take a look soon.

2bezzat commented 6 years ago

sure, take your time 👍

2bezzat commented 6 years ago

@EvanHahn I've deleted my comments, sorry for being late

EvanHahn commented 6 years ago

Thanks! I will deploy a new version in the next week.

EvanHahn commented 6 years ago

Deployed humanize-duration@3.15.2 with this change. Thank you!