Update length of month and year

EvanHahn / HumanizeDuration.js

361000 becomes "6 minutes, 1 second"

https://evanhahn.github.io/HumanizeDuration.js/

The Unlicense

1.64k stars 175 forks source link

Update length of month and year #157

Closed IDisposable closed 3 years ago

IDisposable commented 5 years ago

Since leap years are actually every four years EXCEPT every hundred years but INCLUDING every four-hundred years, the average number of days in a year is 365.2425 not 365.25. This means that the number of days in a month is (on average) 30.436875 days.

This means we have to update all the test data to conform to the correct calculations.

Fixes #156

EvanHahn commented 5 years ago

Mentioned some concerns in #156—let's discuss there unless it's about this fix specifically.

motchju commented 4 years ago

Would be nice to merge it, thanks @IDisposable for the work and @EvanHahn for the repo

EvanHahn commented 4 years ago

For anyone following along here but not in the original issue, I added a comment explaining my plans here.

EvanHahn commented 3 years ago

I just renamed master to main which caused this PR to be automatically closed. I didn't realize this would happen. Apologies!