search

EvanHahn / HumanizeDuration.js

361000 becomes "6 minutes, 1 second"
https://evanhahn.github.io/HumanizeDuration.js/
The Unlicense
1.65k stars 175 forks source link

Remove AMD support #178

Closed EvanHahn closed 4 years ago

EvanHahn commented 4 years ago

The Asynchronous Module Definition (AMD) is a JavaScript module standard that's fallen out of favor.

HumanizeDuration.js currently supports this. We should remove support in the next major version.

It should be a matter of deleting these lines:

https://github.com/EvanHahn/HumanizeDuration.js/blob/6029e9807718a7da2cbb1f859b3e7e0f94049069/humanize-duration.js#L1288-L1291

We'll also remove define from the list of globals, on this line:

https://github.com/EvanHahn/HumanizeDuration.js/blob/6029e9807718a7da2cbb1f859b3e7e0f94049069/humanize-duration.js#L3

This pull request should be made against the v4.0.0 branch, which you can see in #176.

EvanHahn commented 4 years ago

Closed in #186.