search

EvanHahn / HumanizeDuration.js

361000 becomes "6 minutes, 1 second"
https://evanhahn.github.io/HumanizeDuration.js/
The Unlicense
1.64k stars 175 forks source link

removed month and year from units #185

Closed morrme closed 4 years ago

morrme commented 4 years ago

resolves #177

morrme commented 4 years ago

@EvanHahn there might be a typo in the current README at line 156. It has the expected outcome commented out in a nonstandard place.

I didn't want to fix it if it was intentional , but that example should change as well. With the change requested by #177, the "unitMeasures" example changes to "57 weeks, 1 day".

If desired, I can change the expected output to this value, or add the "units" option to the example so that it reflects the current expected output.

EvanHahn commented 4 years ago

You're right—that comment is in a weird place. Would you mind opening a separate pull request for that? (If not, I can do it.)

I think it makes sense to update the expected output, not the units option.

morrme commented 4 years ago

@EvanHahn would you like the fix for the comment to be submitted in a PR against the current branch, and the fix with the updated output to be included in this one for v4.0.0?

EvanHahn commented 4 years ago

@morrme Yeah, that sounds perfect. I'll take another look when you've pushed changes.