search

EvanHahn / HumanizeDuration.js

361000 becomes "6 minutes, 1 second"
https://evanhahn.github.io/HumanizeDuration.js/
The Unlicense
1.64k stars 175 forks source link

Improve Arabic & convert to arabic numbers #198

Closed Misioka closed 3 years ago

Misioka commented 3 years ago

In some cases like e.g. react-native Number.toLocaleString is not working. That's why I have added the convert function to the dictionary.

EvanHahn commented 3 years ago

Does npm test pass after this change? Should you update the Arabic test CSV file?

Misioka commented 3 years ago

@EvanHahnI have updated CSV and now all tests passed.

EvanHahn commented 3 years ago

Thanks! I'll take a look soon.

EvanHahn commented 3 years ago

Thanks! I am going to make some changes in #199 and will merge soon.

EvanHahn commented 3 years ago

This has been deployed in humanize-duration@3.27.0. Thanks again!

I would like to add you to the contributors list. What name and URL should I use?

Misioka commented 3 years ago

Thanks a lot for your work.

I will be honored to become a contributor. You can use the GitHub link https://github.com/Misioka And my name is Michal Karzel

On Sun, Jun 6, 2021, 21:18 Evan Hahn @.***> wrote:

This has been deployed in @.*** Thanks again!

I would like to add you to the contributors list. What name and URL should I use?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/EvanHahn/HumanizeDuration.js/pull/198#issuecomment-855448393, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD6VALJ4O26Z7UQXIGUIZF3TRPCXBANCNFSM45TCFO6A .

EvanHahn commented 3 years ago

I just credited you in 8e03ec0bfc215c4ed48aca250c86ae81c61ccc3b. Thanks again!