search

EvanHahn / HumanizeDuration.js

361000 becomes "6 minutes, 1 second"
https://evanhahn.github.io/HumanizeDuration.js/
The Unlicense
1.65k stars 175 forks source link

Add option to control suffix (delimiter between digits and name of period) #22

Closed darknos closed 10 years ago

darknos commented 10 years ago

Great module thank you. Could you merge this small pull request to make it better :)

darknos commented 10 years ago

one more addition - allows to define language in options

EvanHahn commented 10 years ago

I don't think the name suffix is descriptive enough. Could you change it to separator?

darknos commented 10 years ago

as you wish. :) but delimiter and separator options are also not so descriptive :)

EvanHahn commented 10 years ago

I agree. What would better names be?

darknos commented 10 years ago

Honestly, I didn't read code quite attentive and used the simplest way I found. Yes it would be more correct to leave render function outside.

Do you want I do changes?

EvanHahn commented 10 years ago

I'll do these changes myself, unless you would prefer to do them. Closing for now.