EvanHerman / yikes-inc-easy-mailchimp-extender

Easy Forms for MailChimp WordPress Plugin
http://yikesplugins.com
GNU General Public License v2.0
25 stars 28 forks source link

Placeholder text not appearing #112

Closed modernnow closed 10 years ago

modernnow commented 10 years ago

Hi, I have installed and configured the plugin and it works very well (Thank you) however I am not getting the placeholder text. I would like it to display the field name eg. Email Address... here is the html

EvanHerman commented 10 years ago

Hi Modernnow,

If you temporarily switch to a default bundled theme such as Twenty Thirteen or Twenty Fourteen are you still unable to get the placeholders to display? Can you provide a link to a page where you are trying to display the placeholders on?

Thanks, Evan

modernnow commented 10 years ago

Hi

Sure,

http://modernnow.com/wp/modernnow/

Its in the footer under the heading MODERN NOW UPDATES

Thank you

On Aug 25, 2014, at 2:42 PM, Evan Herman notifications@github.com wrote:

Hi Modernnow,

Can you provide a page where you are trying to display the placeholders on?

Thanks, Evan

— Reply to this email directly or view it on GitHub.

EvanHerman commented 10 years ago

Hi Modernnow,

What is the value you've entered into the placeholder field on the list page? On the front end, I don't see the value being passed along to the input field. It has no value, which means the placeholder wasn't set in the back end, or their was an issue with it passing it to the front end. If you inspect the code on the page, and look for the element with the class eb12a83563EMAIL_placeholder_value , you'll see what I'm referring too.

Thanks, Evan

modernnow commented 10 years ago

Yes I saw that the placeholder was blah, maybe i didn’t realize there was a place to set it… I will look for this setting…. I did search for it thinking this was the case and didn’t see where the field was. i will have another look now. On Aug 25, 2014, at 5:07 PM, Evan Herman notifications@github.com wrote:

Hi Modernnow,

What is the value you've entered into the placeholder field on the list page? On the front end, I don't see the value being passed along to the input field. It has no value, which means the placeholder wasn't set in the back end, or their was an issue with it passing it to the front end. If you inspect the code on the page, and look for the element with class "eb12a83563EMAIL_placeholder_value" , you'll see what I'm referring too.

Thanks, Evan

— Reply to this email directly or view it on GitHub.

modernnow commented 10 years ago

Yes thats it, I saw the merge keys but didn’t read further into it to see that was a merge key for placeholder and that I had to enter a value. it is solved now.

On another note there is an annoying thing happening, I work in safari but your plug-in will not recognize an API entered into Safari browsers, it will in firefox. The trouble is every time that I log into safari and go into the plugin it resets the API and I have to go over to firefox and reenter it.

And lastly I had to edit the css directly because when I copy your style sheet to my child it won’t recognize the changes. Is there something I am doing wrong with it?

Thank you for all your great work I love this plugin and will support it.

On Aug 25, 2014, at 5:07 PM, Evan Herman notifications@github.com wrote:

Hi Modernnow,

What is the value you've entered into the placeholder field on the list page? On the front end, I don't see the value being passed along to the input field. It has no value, which means the placeholder wasn't set in the back end, or their was an issue with it passing it to the front end. If you inspect the code on the page, and look for the element with class "eb12a83563EMAIL_placeholder_value" , you'll see what I'm referring too.

Thanks, Evan

— Reply to this email directly or view it on GitHub.

EvanHerman commented 10 years ago

Hi Modernnow,

The placeholder input field actually has a placeholder text (email) in it, to indicate that you can input text into that field ( a bit confusing ). The text "Email Address" that is set as a placeholder won't actually display on the front end. Check the screenshot as a reference. If you enter the text into that field, and then resave the specific form, it should then display on the front end.

Refrence

EvanHerman commented 10 years ago

Great, I'm glad you got the issue resolved. In future releases we will look into adding a little more instruction to avoid confusion.

Evan

EvanHerman commented 10 years ago

Sorry I missed your previous response, it seems to be hidden inside of a comment or something.

On another note there is an annoying thing happening, I work in safari but your plug-in will not recognize an API entered into Safari browsers, it will in firefox. The trouble is every time that I log into safari and go into the plugin it resets the API and I have to go over to firefox and reenter it. And lastly I had to edit the css directly because when I copy your style sheet to my child it won’t recognize the changes. Is there something I am doing wrong with it? Thank you for all your great work I love this plugin and will support it.

I'm not sure why it resets inside of safari only, but I do know a fix we can implement into the next release that will help prevent it. I will need to add in a conditional that will prevent the API check from running on page load.

In regards to the CSS, you shouldn't need to copy over the CSS file into your child theme. I would just add styles directly to your child themes style.css file directly, and it should override the styles loaded by our plugin.

Thanks, Evan

TheTracyL commented 10 years ago

If you add your styles back to your child theme I can inspect and look into it.

modernnow commented 10 years ago

great on the safari patch, and on the css I will do that i will add them directly into my child style.css and give it a try. Thanks On Aug 25, 2014, at 5:21 PM, Evan Herman notifications@github.com wrote:

Sorry I missed your previous response, it seems to be hidden inside of a comment or something.

On another note there is an annoying thing happening, I work in safari but your plug-in will not recognize an API entered into Safari browsers, it will in firefox. The trouble is every time that I log into safari and go into the plugin it resets the API and I have to go over to firefox and reenter it. And lastly I had to edit the css directly because when I copy your style sheet to my child it won’t recognize the changes. Is there something I am doing wrong with it? Thank you for all your great work I love this plugin and will support it.

I'm not sure why it resets inside of safari only, but I do know a fix we can implement into the next release that will help prevent it. I will need to add in a conditional that will prevent the API check from running on page load.

In regards to the CSS, you shouldn't need to copy over the CSS file into your child theme. I would just add styles directly to your child themes style.css file directly, and it should override the styles loaded by our plugin.

Thanks, Evan

— Reply to this email directly or view it on GitHub.

modernnow commented 10 years ago

Hi

I ran a validation of the site and I am getting an error on the form. It does not like the rel value of 0-eb12a83563

Line 451, Column 104: Bad value 0-eb12a83563 for attribute rel on element form: The string 0-eb12a83563 is not an absolute URL. …e="yks-mailchimp-form" id="yks-mailchimp-form_0-eb12a83563" rel="0-eb12a83563"> Syntax of absolute URL: An absolute URL. For example: http://example.org/hello, but not /hello. Spaces should be escaped as %20.

On Aug 25, 2014, at 5:22 PM, Tracy Levesque notifications@github.com wrote:

If you add your styles back to your child theme I can inspect and look into it.

— Reply to this email directly or view it on GitHub.