search

EvanOxfeld / angular-selectize.js

Angular Selectize directive for a hybrid textbox + <select> box. Supports ngOptions and two-way bindings.
MIT License
34 stars 16 forks source link

Fix ng-option filter expressions #17

Closed stgeorge closed 10 years ago

stgeorge commented 10 years ago

Fixes #5

Chris-Gillis commented 10 years ago

Nice fix!

Would you mind adding a test for this scenario?

Edit: I just noticed you said you are unable to test. Is there something I can do to help you with that?

stgeorge commented 10 years ago

I don't have a nodejs setup or much time to look into setting it up at the moment unfortunately - I'll have to leave it up to someone else to make a functional test. My apologies.

EvanOxfeld commented 10 years ago

@stgeorge I appreciate your help getting filter expressions to work!

Please don't worry about tests -- fortunately you got me most of the way (ok, all of the way :smile:), and this scenario is pretty straightforward to write tests for.

EvanOxfeld commented 10 years ago

I thought I discovered an issue with this change, but instead there was a bug in the version of selectize I usually test against that must have been fixed between 0.9.0 and 0.11.0. When I have a chance to work on this again, I'll determine the new minimum version of selectize and write a couple tests.

For now, I welcome comments on the plunk I've been testing with: http://plnkr.co/edit/mO7ssw?p=preview

EvanOxfeld commented 10 years ago

Merged and published as version 1.4.0. I added a few tests as well as multiselect ngoption filter expression support.

Thanks again for the fix, @stgeorge!

stgeorge commented 10 years ago

Thanks @EvanOxfeld and keep up the good work on this library!