Fix `finish` and `close`

EvanOxfeld / node-unzip

node.js cross-platform unzip using streams

MIT License

613 stars 343 forks source link

Closed ZJONSSON closed 7 years ago

ZJONSSON commented 8 years ago

Under some circumstances the unzip stream can end up in limbo without emitting finish or close. Here we simplify the end mechanism as follows:

end on the main stream does nothing, because we dont want to end until the pullsteam is done
When pullstream is finished the prototype end function is applied to the unzip stream and close is emitted

klaaz0r commented 8 years ago

When will this be merged in production?

ZJONSSON commented 8 years ago

@klaaz0r An experimental fork that addresses some of the streaming issues I have experienced. https://www.npmjs.com/package/unzipper

with the following modifications: https://github.com/ZJONSSON/node-unzipper/commit/a8177dafd88cadf54eac78dd2d5c7429391e0271 Pullstream was refactored within the repo to address the scenario when inbound stream is slow (i.e. ftp) and the buffer might not be available when Pull is called. Feedback appreciated.

deanshub commented 7 years ago

👍

swb2016 commented 6 years ago

Thanks!!

sohailalam2 commented 6 years ago

Thanks!! 👍 :)