DO NOT USE THIS THING - Githubissues

EvanOxfeld / node-unzip

node.js cross-platform unzip using streams

MIT License

613 stars 343 forks source link

DO NOT USE THIS THING #120

Open mmontag opened 5 years ago

mmontag commented 5 years ago

Just a warning to amplify the sentiments of others here and on StackOverflow.

See https://stackoverflow.com/a/46967462/264970

mmontag commented 5 years ago

If you have already written code against unzip and are having problems, try https://www.npmjs.com/package/unzipper, which should be a drop-in replacement. Worked for me.

nicolas-cherel commented 5 years ago

whoa, lost a few hours trying to figure out why it was not working for my use case, and it really looked like it wasn't consuming my stream properly. thanks for the reminder :)

grigorkin commented 5 years ago

Fantastic! I've spent almost a day to find the problem in my code, but the problem was in that lib.

kalinchernev commented 5 years ago

@mmontag thank you so much for this thread. I did spent hours with issues with this package and unzipper did work as a drop-in replacement without any issues inside modern async code! Thank you so much!

shaunwarman commented 5 years ago

Wooh. Thanks!

Gi60s commented 5 years ago

Wow, thanks for this issue. I've been tracing weird file behavior for hours. Couldn't figure out why intermittently I couldn't overwrite a file that had been unzipped. Following this post I think it couldn't overwrite the file because it's file handle was probably still in use.

Thanks a ton @mmontag

IanDavey commented 5 years ago

Thanks, @mmontag! After spending a day writing code that uses this it's fantastic to have a drop-in replacement.

dobromyslov commented 3 years ago

@EvanOxfeld I hope you are alive. Could you please mark this package as deprecated? It will help to make NodeJS ecosystem less cluttered.