Cryptocurrency rates not working

ghost commented 5 years ago

For a few days now, the cryptocurrency rates haven't been working. Any ideas why?

Actually, looking at it, I think all the rates are down.

Thanks

EvanRespaut commented 5 years ago

Looks like the yahoo source I've been pulling from is down: https://finance.yahoo.com/webservice/v1/symbols/allcurrencies/quote

Not sure if it's down for good or just temporary.

ghost commented 5 years ago

You can get the ECB rates directly. I believe it's updated once a day at 3pm: http://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml

Not sure how many currencies you get from yahoo, but a quick look at the above feed shows 32 currencies against the euro. Obviously from there you can calculate any pair.

As for cryptocurrencies, I posted it elsewhere but to save jumping around, here's the top 1000: https://api.coinmarketcap.com/v1/ticker/?limit=1000

I suppose grabbing info from multiple sources would help in situations like this.

tmlee commented 5 years ago

For cryptocurrency data, I would like to suggest giving our API a shot at https://www.coingecko.com/api/docs/v3

Should be straighforward to get started and easy to consumer.

Let me know your thoughts

EvanRespaut commented 5 years ago

That ECB api looks pretty solid, although not nearly the same number as Yahoo. That had something like all 160 currencies plus precious metals. If I switch to ECB, I'll should probably delete the other currencies that will always be outdated.

For crypto, I'm already using coinmarketcap, although the broken Yahoo call breaks that too, so I can fix that.

tmlee commented 5 years ago

Sounds good. in any case cmc will soon require api key and registration, if you are looking for a workaround that you may consider our api as an option

cbix commented 5 years ago

Any decisions so far on changing the source of the exchange rates? You could also allow the user to choose from different sources, like this app does: https://github.com/hwki/SimpleBitcoinWidget However that's not trivial to implement probably...

EvanRespaut commented 5 years ago

Added support to pull rates from ECB. Update is live as of yesterday. Let me know if there are issues.

ghost commented 5 years ago

It would nice if a lot more cryptos were included, or at least the top 100.

Gold and silver is no longer available?

Thank you very much.

ghost commented 5 years ago

Tip incoming

cbix commented 5 years ago

Added support to pull rates from ECB. Update is live as of yesterday. Let me know if there are issues.

I was not able to build the latest master, will try again later. If it's the final 1.7 release, could you tag it and maybe upload the APK to the github releases (or attach here as .zip) until it appears on F-Droid?

EDIT: nevermind, I updated Android Studio and it worked. But now UAH (ukrainian hrywnia) is missing :(

cbix commented 5 years ago

https://f-droid.org/wiki/page/com.llamacorp.equate/lastbuild

F-droid seems to have issues buidling 1.7, but it looks like a problem in the f-droid tools:

FAILURE: Build failed with an exception.
* What went wrong:
A problem occurred configuring root project 'com.llamacorp.equate'.
> Could not resolve all files for configuration ':classpath'.
    > Could not download gradle-core.jar (com.android.tools.build:gradle-core:2.3.3)
        > Could not get resource 'https://jcenter.bintray.com/com/android/tools/build/gradle-core/2.3.3/gradle-core-2.3.3.jar'.
            > Connection reset
* Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED

EvanRespaut commented 5 years ago

I made an update that adds back in almost all currencies, sourced from here:http://www.floatrates.com/daily/usd.json Let me know if people have issues!

JKAbrams commented 4 years ago

The Bitcoin price is incorrect, Equate currently reports the price at $8740 while Bitstamp has $5519.

BTC is lacking from the .json you linked.

zuluqq commented 4 years ago

Second this ^. 1 BTC = $3,197.67 USD in the app; it should be twice this. The BTC/ETH rates also need updating (₿0.02, not ₿0.08).