EvanRespaut / Equate

Unit converting calculator
GNU General Public License v3.0
67 stars 17 forks source link

Currency unit Dash, not correct value #61

Open xcelente opened 3 years ago

xcelente commented 3 years ago

I'm not sure why the Dash price stopped working, it's not the price from Coinpaprika.

While I'm here, can you add Decred and Beam to the price feed (DCR, BEAM)?

Thanks

xcelente commented 3 years ago

I have figured out why the dash price is wrong.

Different coins can have the same symbol. That's stupid, I know, but that's what it is happening, it is showing the price of DoorDash because it has the same symbol. To get the real price of dash, you need to extract by the id "dash-dash". Look at the raw json that is being fetched to see what I mean.

The other way to do this, is to ignore duplicate symbols with a lower rank. I guess that would work until DoorDash goes higher than the real dash. :-)