search

Evannessa / Journal-To-Canvas-Slideshow

FoundryVTT Project
8 stars 9 forks source link

Don't works in 0.8.6 #19

Open Varkal opened 3 years ago

Varkal commented 3 years ago

Hi !

I've upgraded my Foundry server to 0.8.6. I'm aware the module.json doesn't claim it's compatible with this foundry version.

And obviously, it's not :-)

At the loading of the game I got this error in the console : 

foundry.js:197 TypeError: Cannot read property 'parentNode' of undefined
    at applySceneHeaderButtons (ClickImageInJournal.js:595)
    at ClickImageInJournal.js:848
    at Function._call (foundry.js:194)
    at Function.call (foundry.js:179)
    at CompactJournalEntryDisplay._render (foundry.js:2096)
    at async CompactJournalEntryDisplay._render (foundry.js:2728)
    at async CompactJournalEntryDisplay._render (foundry.js:25348)

Click on the "Create or Show Display Scene" throw : 

ClickImageInJournal.js:436 Uncaught (in promise) TypeError: scenes is not iterable
    at DisplaySceneFound (ClickImageInJournal.js:436)
    at HTMLButtonElement.GenerateDisplayScene (ClickImageInJournal.js:341)
    at HTMLButtonElement.dispatch (jquery.min.js:2)
    at HTMLButtonElement.v.handle (jquery.min.js:2)

Open any journal entry throw 

foundry.js:197 TypeError: journalEntries.forEach is not a function
    at FindDisplayJournal (ClickImageInJournal.js:63)
    at ClickImageInJournal.js:852
    at Function._call (foundry.js:194)
    at Function.call (foundry.js:179)
    at s._render (foundry.js:2096)
    at async s._render (foundry.js:2728)
    at async s._render (foundry.js:25348)

And click on picture throw : 

ClickImageInJournal.js:436 Uncaught (in promise) TypeError: scenes is not iterable
    at DisplaySceneFound (ClickImageInJournal.js:436)
    at displayImageInScene (ClickImageInJournal.js:219)
    at HTMLImageElement.determineLocation (ClickImageInJournal.js:476)

I hope that will help you if you plan to make this module compatible with the next version of foundry :-)

If I free me some time this week maybe i can try to make you a PR for this ?

Evannessa commented 3 years ago

Hey there! No worries -- I definitely intend to make this module compatible with the 8.6 version of Foundry. :) I've been working on it and I seem to have got the features all working with only a few minor tweaks so far, but want to do some more testing to make sure it's solid, so hopefully I should be able to get it out sometime this week. ^ ^

Thanks for your patience!

On Sun, Jun 6, 2021 at 4:24 AM Romain Moreau @.***> wrote:

Hi !

I've upgraded my Foundry server to 0.8.6. I'm aware the module.json doesn't claim it's compatible with this foundry version.

And obviously, it's not :-)

At the loading of the game I got this error in the console :

foundry.js:197 TypeError: Cannot read property 'parentNode' of undefined at applySceneHeaderButtons (ClickImageInJournal.js:595) at ClickImageInJournal.js:848 at Function._call (foundry.js:194) at Function.call (foundry.js:179) at CompactJournalEntryDisplay._render (foundry.js:2096) at async CompactJournalEntryDisplay._render (foundry.js:2728) at async CompactJournalEntryDisplay._render (foundry.js:25348)

Click on the "Create or Show Display Scene" throw :

ClickImageInJournal.js:436 Uncaught (in promise) TypeError: scenes is not iterable at DisplaySceneFound (ClickImageInJournal.js:436) at HTMLButtonElement.GenerateDisplayScene (ClickImageInJournal.js:341) at HTMLButtonElement.dispatch (jquery.min.js:2) at HTMLButtonElement.v.handle (jquery.min.js:2)

Open any journal entry throw

foundry.js:197 TypeError: journalEntries.forEach is not a function at FindDisplayJournal (ClickImageInJournal.js:63) at ClickImageInJournal.js:852 at Function._call (foundry.js:194) at Function.call (foundry.js:179) at s._render (foundry.js:2096) at async s._render (foundry.js:2728) at async s._render (foundry.js:25348)

And click on picture throw :

ClickImageInJournal.js:436 Uncaught (in promise) TypeError: scenes is not iterable at DisplaySceneFound (ClickImageInJournal.js:436) at displayImageInScene (ClickImageInJournal.js:219) at HTMLImageElement.determineLocation (ClickImageInJournal.js:476)

I hope that will help you if you plan to make this module compatible with the next version of foundry :-)

If I free me some time this week maybe i can try to make you a PR for this ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/EvanesceExotica/Journal-To-Canvas-Slideshow/issues/19, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADD56RFKHCQVUMS2TZ4YPGTTRMWDBANCNFSM46FUR3AA .

mech-tools commented 3 years ago

Hello @EvanesceExotica still got these errors on 0.8.7

Evannessa commented 3 years ago

Ah, darn, okay! Let me do some more testing and see if I can figure out what's up.

mech-tools commented 3 years ago

@EvanesceExotica it seems that you are relying on another module to share an image

image

mech-tools commented 3 years ago

Fixed with you own package name: journal-to-canvas-slideshow And adding "socket": "true", to module.js

mech-tools commented 3 years ago

@EvanesceExotica attempt to fix some errors: https://github.com/EvanesceExotica/Journal-To-Canvas-Slideshow/pull/21

Couldn't reproduce all errors. But I believe those are fixed: