search

Evannessa / Journal-To-Canvas-Slideshow

FoundryVTT Project
8 stars 9 forks source link

module does not take routePrefix into account #31

Open MartijnSanders opened 2 years ago

MartijnSanders commented 2 years ago

Foundry has a feature to set a routePrefix in foundrydata/Config/options.json

routePrefix is a path which is appended to the base hostname to serve Foundry VTT content from a specific namespace. For example setting this to demo will result in data being served from http://x.x.x.x:30000/demo/.

Journal-To-Canvas-Slideshow does not take this route into account and cannot create the DisplayTile if FoundryVTT is hosted using this feature.

This can be solved by calling the foundry.utils.getRoute utility function. Below is a screenshot of the 7 lines that need to be changed

Screenshot 2022-05-19 at 23 10 26
Evannessa commented 2 years ago

Apologies for replying to this so late! I've been very busy with school and health issues this past year and have only been able to get back to this module in the past few months, so thank you so much for your patience.

This module just received a huge update where I overhauled the entire code-base. The way Display Tiles (now called 'Art Tiles'), and Bounding Tiles (now called 'Frame Tiles') work has been completely reworked and refactored and is not longer reliant on accessing a particular image file, as now any tile in a scene can be set to become a "Frame" or "Art" tile and you can change its image independently ^ ^

Here's a gif showing off the new tile "linking" functionality: Linking pre-existing tile demo

You can read up on some of the updated functionality here in the feature walkthrough's section on Art Tiles and Frame Tiles

This latest update should hopefully solve the issue you were having entirely, so feel free to give it a try and let me know!

Note that the latest official published update (v2.1) doesn't support Foundry v10 just yet, so if you've already updated to Foundry v10, I'm working on an experimental branch that does support v10 (with v9 backwards compatibility).

You can install by pasting the below URL into the textbox at the bottom of the Install Module screen in Foundry and clicking Install:

https://raw.githubusercontent.com/EvanesceExotica/Journal-To-Canvas-Slideshow/v10-migration-experimental/module.json

Let me know if that fixes things for you, and thank you so much for your patience!