Open Vincekettu opened 1 year ago
Hello! Sorry for the issues you're having. May I ask which version of Foundry you're using?
If you're using Foundry v10, it's likely not installing for you because the module.json file is outdated for v10. The "release" version of this module right now is only officially compatible with Foundry v9.
But I'm working on a pre-release version on another branch that you can try out to see if it works for you!
I have tested that version in v10 and v9 and most of the basic functionality seems to work, but it could use further testing before I publish it.
Just paste the link below into the text box at the bottom of the "Install Module" window to install the experimental v10 version:
Let me know if that works for you, or if you run into any further issues. The official update for v10 should be coming soon.
I do have a problem with your experimental build.
Whenever I click on an image in the journal it opens it in a popup as if you'd clicked on "Display image in pop-out window", and it also activates the image on the default art tile.
I think the default foundry behaviour should be overwritten, but isn't?
Rest works as expected as far as I can tell.
It's usable, but not quite as practical this way.
Ah, yep, that is a problem that I'm aware of. You should be able to right-click on the image instead and it should (hopefully) work as intended without also activating the default Foundry Popout.
Right-clicking is also the required behavior for images on Actor and Item sheets, since left-clicking an image on those sheets often causes the file picker to open so you can change the image.
It's definitely a bit of a pain in the butt, and I'm weighing whether it'd be worth it to try and disable or reroute the default functionality on all the sheets, or if right-clicking instead (or the equivalent on your OS: https://developer.mozilla.org/en-US/docs/Web/API/Element/contextmenu_event) would be a painless enough alternative.
I'll definitely update the documentation to make this issue more clear ^ ^ Let me know if that helps!
Apologies, I could've sworn I already pushed the changes to the v10 experimental version that allows you to right click on journal images. It should be updated now, though. You'll likely need to paste the Manifest URL into the Install Module window again for it to update.
Apologies, I could've sworn I already pushed the changes to the v10 experimental version that allows you to right click on journal images. It should be updated now, though. You'll likely need to paste the Manifest URL into the Install Module window again for it to update.
Works good. I thought it'd take some time to getting used to, but it's very intuitive. New users won't ever think about left clicking the image.
Now it's even better, because you can preview a big version of the image before showing them to the players.
Impossible to install from the Add-on module.
console gives : Error: Unable to load valid module manifest data from "https://raw.githubusercontent.com/EvanesceExotica/Journal-To-Canvas-Slideshow/master/module.json" Module Model Validation Errors [Module.relationships]: Model Validation Errors [Module.relationships.requires]: Model Validation Errors Model Validation Errors [id]: may not be a blank string