search

Evannessa / Journal-To-Canvas-Slideshow

FoundryVTT Project
8 stars 9 forks source link

CSS Specificity w/ Forien's Quest Log #48

Open typhonrt opened 1 year ago

typhonrt commented 1 year ago

Greets,

I'm the developer / maintainer of FQL. An issue was opened regarding CSS specificity issue when JTCS is enabled. It is due to CSS in JCTS that is too generic. I see there are several other issues open / raised with other clashes with modules with this package. The particular conflicting CSS rule in JCTS is .square in _utility.scss#L642-645. In taking a quick gander at the CSS for this module there likely will be any number of CSS conflicts with other FVTT packages including game systems. I recommend improving the specificity when you can as conflicts will occur.

Example results when JCTS is enabled where .square throws off the layout of FQL:

Screen Shot 2023-04-08 at 3 34 47 AM

The correct layout when JCTS .square is disabled:

Screen Shot 2023-04-08 at 3 35 20 AM
Evannessa commented 1 year ago

Hello! Apologies for the late reply; life's been quite busy these past few months! Thanks for bringing this to my attention -- I'll take a look into it as soon as I can.

typhonrt commented 1 year ago

No worries, it's definitely a good practice to be as specific as possible keying things w/ an ID on an element (app ID) then have your classes from there, etc. This is the biggest source of general conflicts I've seen between Foundry packages; probably ~3 reported in last few months against FQL. The negative effects are seen in FQL when your module is also active, so only hits folks running both at the same time.