search

Eve-ning / vsrg

a c++ static library for vsrg
https://twitter.com/dev_evening
2 stars 0 forks source link

Converts LongNote to inherit from Hit Object #11

Closed Eve-ning closed 5 years ago

Eve-ning commented 5 years ago

Ran into a few issues when LongNote was a wrapper for a pair of HitObjects, I feel like it's a bit too specific, non-extensible and error prone.

I feel like it'd be better if it's converted into a GroupedHitObject Class in vsrg_extend since it'll be complex but easily understandable and inheritable

This PR pretty fixes this and pushes the idea to vsrg_extend