search

Eve-ning / vsrg

a c++ static library for vsrg
https://twitter.com/dev_evening
2 stars 0 forks source link

Rename calculated functions differently #3

Closed Eve-ning closed 4 years ago

Eve-ning commented 4 years ago

Currently getFunctions have 2 types, one in which just returns the held data member and one in which returns a modified data member.

May need to rename them differently to signify that an operation is performed on them as to avoid any performance issues. Though it sounds too minute to consider I think it'll avoid versioning issues for dependent libraries later on

Eve-ning commented 4 years ago

Likely will not affect performance, so far the only issue I saw was the conversion of ms to s to min to hour. I might just comment to suggest using ms instead

Eve-ning commented 4 years ago

Functions should be clear on return type and value. If modified, the user should be aware of it. Ultimately, it function names should be clear enough to show what is going on.

Will close this as this is a pretty abstract problem, however, will keep note of the rule of thumb