search

Eve-ning / vsrg

a c++ static library for vsrg
https://twitter.com/dev_evening
2 stars 0 forks source link

HitObject Column should be Index and drop starts_from #7

Closed Eve-ning closed 4 years ago

Eve-ning commented 4 years ago

Why it should be index While it is a Vertical game, it can be implemented differently with 2 rows of notes, I think using Column could be confusing, likely we need to change to Index, leave it to how each game implements getColumn and setColumn.

Drop starts_from Starts from is made due to games having different formats for what is a Column and should it start from 0 or 1. I think with the above change, it should be left to the parser on how it offsets it. This function currently masks the performance.

Eve-ning commented 4 years ago

Incorrect commit references. They should link here ed25578502360a18d744b009d5f4f0f676950b34 27726cae5a0b693d0df91fce166d194eab595c88

These Closes this issue