search

Eve-ning / vsrg

a c++ static library for vsrg
https://twitter.com/dev_evening
2 stars 0 forks source link

Add an Exception Class #8

Open Eve-ning opened 4 years ago

Eve-ning commented 4 years ago

Some functions are returning ambiguously, where false can mean different meanings.

If using methods on an already invalid isValid() == false object, it should throw an exception

Eve-ning commented 4 years ago

I added a commit 5532a31d0c574e54d758e581f6803a4af1fa6fc8 where it uses BOOST_ASSERT_MSG to just throw an error with message instead of creating an exception.

I will consider this if it's really necessary however.

Eve-ning commented 4 years ago

Personally think that a custom exception class isn't needed at this stage, however, once the error messages start to pile up w.r.t. BOOST_ASSERT_MSG, then I'll consider