EvenAR / node-simconnect

A cross platform SimConnect client library for Node.JS
GNU Lesser General Public License v3.0
95 stars 33 forks source link

It looks like open() logs a registry key on failure #68

Closed Pomax closed 1 year ago

Pomax commented 1 year ago

When running the following code, the library seems to log the MSFS Windows registry key to the console:

import { open, Protocol } from "node-simconnect";
try {
    await open("My app", Protocol.KittyHawk);
} catch (e) {
    // ignore the error
}

Logs:

D:\temp>node test.js
{"HKCU\\Software\\Microsoft\\Microsoft Games\\Flight Simulator": "

D:\temp>

When MSFS isn't running, or loading in.

When MSFS is fully loaded, that console log does not occur.

EvenAR commented 1 year ago

Weird. Looks like bumping the regedit dependency solved it. Thanks for the issue!

Pomax commented 1 year ago

Silly request, but could that update be published as v3.4.1? =D

(that way I can bump the api wrapper package, too)

EvenAR commented 1 year ago

Silly request, but could that update be published as v3.4.1? =D

(that way I can bump the api wrapper package, too)

New version published :)

Pomax commented 1 year ago

❤️