Remove autoAck from Persistent Subscriptions

EventStore / EventStore-Client-Dotnet

Dotnet Client SDK for the Event Store gRPC Client API written in C#

Other

143 stars 37 forks source link

Remove autoAck from Persistent Subscriptions #175

Closed hayley-jean closed 2 years ago

hayley-jean commented 2 years ago

Removes autoAck option when connecting to Persistent Subscriptions. Going forward, subscribers will need to explicitly ack/nack messages using subscription.Ack(evnt);.

See the docs here for instructions on how to ack/nack manually.

Fixes https://github.com/EventStore/EventStore/issues/3113

hayley-jean commented 2 years ago

@hayley-jean Regression / regression-ubuntu-18.04/EventStore.Client.Streams-20.6.0 tests are failing, I'm not sure it that's expected.

The regression test is failing because of a previous regression to do with deleted streams, so it's expected