search

EventStore / EventStore-Client-Dotnet

Dotnet Client SDK for the Event Store gRPC Client API written in C#
Other
140 stars 38 forks source link

Stop connection loop on dispose (DEV-94) #259

Closed pvanbuijtene closed 1 year ago

pvanbuijtene commented 1 year ago

Fixed: Client continues to attempt connecting to the server after being disposed.

Closes #257

timothycoleman commented 1 year ago

thanks! looks good, i'll approve after the PR this depends on is merged

linear[bot] commented 1 year ago
DEV-94 Client continues to invoke the ChannelInfo factory after being disposed

The channels themselves have been disposed so this doesn't result in additional external calls, but the SharingProvider continues retrying indefinitely, causing a lot of exceptions. This is mitigated by the fact that the typical usage is to instantiate a singleton of the client and not dispose it (but we should definitely fix it still)