search

EventStore / EventStore-Client-Go

Go Client for Event Store version 20 and above.
Apache License 2.0
103 stars 25 forks source link

Remove RequiresLeader option from persistent subscription #181

Closed seanppayne closed 2 months ago

seanppayne commented 2 months ago

Changed: Remove RequiresLeader option from persisent subscription API.

Addresses issue #176

seanppayne commented 2 months ago

@YoEight I haven't run tests locally, so if there are any issues with the CI run I will adjust after. Thank you

seanppayne commented 2 months ago

@YoEight 

Warning: go-version input was not specified. The action will try to use pre-installed version.

This shows for both the windows & mac checks. It seems the following var in Github is not set. Can you check when you have time?

    steps:
      - uses: actions/checkout@v4
      - uses: actions/setup-go@v5
        with:
          go-version: ${{ vars.GO_VERSION }}
YoEight commented 2 months ago

Hey @seanppayne , you can't resolve that variable because you did a fork (we were not aware of that limitation). I came up with a patch to fix it and I suggest you to rebase your fork when that PR get merged. Sorry for delaying your review:

https://github.com/EventStore/EventStore-Client-Go/pull/182

seanppayne commented 2 months ago

@YoEight The tests passed. Please take a look when you have time.