search

EventStore / EventStore-Client-NodeJS

A NodeJS client for Event Store
https://eventstore.com
Apache License 2.0
162 stars 22 forks source link

[DEV-204] Upgrade grpc-js to 1.9.12 #351

Closed w1am closed 10 months ago

w1am commented 11 months ago

Changed: Upgraded gRPC-JS version from 1.9.0 to 1.9.12.

Fixed: Linting issues Added: Explanations for the discrepancy in the keepalive ping error. DEV-204

w1am commented 11 months ago

@jokesterfr, we are experiencing a discrepancy in the error messages sent to us by the grpc-js library after the upgrade. We receive different error messages in CI and latest when the connection is shut down while reading events from a stream. I have submitted a PR to address the potential bug in the grpc repository.

In the meantime, you to use the resolutions feature if you are using Yarn, or overrides in npm, to pin to the newer version of grpc-js until the PR is merged.

jokesterfr commented 10 months ago

Any plan for a merge of this PR? Thank you

w1am commented 10 months ago

@jokesterfr Sorry for taking time to respond. We'll merge it soon.