search

EventStore / EventStore.Charts

EventStore official Helm Charts
Other
29 stars 47 forks source link

Custersize documentation default does not match actual value #36

Open GoatCodeNL opened 5 years ago

GoatCodeNL commented 5 years ago

Is this a request for help?: No

Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

Version of Helm and Kubernetes:

Client: &version.Version{SemVer:"v2.14.0", GitCommit:"05811b84a3f93603dd6c2fcfe57944dfa7ab7fd0", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.14.0", GitCommit:"05811b84a3f93603dd6c2fcfe57944dfa7ab7fd0", GitTreeState:"clean"}

Which chart: eventstore/eventstore

What happened: Deployed a new eventstore to kubernetes. Documentation states that clustersize is 3, yet it actually is 1.

What you expected to happen: Cluster to be size 3

How to reproduce it (as minimally and precisely as possible): helm install -n eventstore eventstore/eventstore

Anything else we need to know: This was changed in https://github.com/EventStore/EventStore.Charts/pull/30. I think it was accidentally committed as the PR does not give any reason to decrease default cluster size.

GoatCodeNL commented 5 years ago

Fixed in: https://github.com/EventStore/EventStore.Charts/pull/37

ameier38 commented 5 years ago

In the description of #30

So that port forwarding works out of box I think it is better to set the default clusterSize=1.

My mistake to not update the docs. Only reason it was changed to 1 was so that the port-forwarding worked out of the box to help with debugging. Otherwise the only I could figure out how to debug locally was using a tool like telepresence.