search

EventStore / EventStore.Charts

EventStore official Helm Charts
Other
29 stars 47 forks source link

Unable to set clusterSize due to: "incompatible types for comparison" #53

Open paw-eloquent-safe opened 4 years ago

paw-eloquent-safe commented 4 years ago

BUG REPORT

Version of Helm and Kubernetes:

Helm Version

version.BuildInfo{Version:"v3.0.2", GitCommit:"19e47ee3283ae98139d98460de796c1be1e3975f", GitTreeState:"clean", GoVersion:"go1.13.5"}

Kubernetes Version

Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.0", GitCommit:"70132b0f130acc0bed193d9ba59dd186f0e634cf", GitTreeState:"clean", BuildDate:"2019-12-13T11:52:47Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"darwin/amd64"}

Server Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.0", GitCommit:"70132b0f130acc0bed193d9ba59dd186f0e634cf", GitTreeState:"clean", BuildDate:"2019-12-07T21:12:17Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"linux/amd64"}

Which chart:

0.2.5

What happened:

localhost:eventstore kim$ helm repo add eventstore    

https://eventstore.github.io/EventStore.Charts
"eventstore" has been added to your repositories

localhost:eventstore kim$ helm repo update 

Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "eventstore" chart repository
Update Complete. ⎈ Happy Helming!⎈ 

localhost:eventstore kim$ helm install eventstore eventstore/eventstore --set clusterSize=3
Error: template: eventstore/templates/NOTES.txt:12:10: executing     
"eventstore/templates/NOTES.txt" at <gt .Values.clusterSize 1.0>: error calling gt: incompatible       
 types for comparison

localhost:eventstore kim$ helm install eventstore eventstore/eventstore --set clusterSize=3.0
Error: template: eventstore/templates/NOTES.txt:12:10: executing  
"eventstore/templates/NOTES.txt" at <gt .Values.clusterSize 1.0>: error calling gt: incompatible 
types for comparison

What you expected to happen:

localhost:eventstore kim$ helm install eventstore eventstore/eventstore --set clusterSize=3
NAME: eventstore
LAST DEPLOYED: Mon Dec 30 20:53:08 2019
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
Event Store is installed!

localhost:eventstore kim$ kubectl get pods
NAME                                READY   STATUS    RESTARTS   AGE
eventstore-0                        1/1     Running   0          100s
eventstore-1                        1/1     Running   0          70s
eventstore-2                        1/1     Running   0          44s
eventstore-admin-55748b87b9-psqpn   1/1     Running   0          100s

How to reproduce it (as minimally and precisely as possible):

brew install minikube

brew install helm 

brew install kubectl

helm repo add eventstore    

helm repo update 

helm install eventstore eventstore/eventstore --set clusterSize=3

Anything else we need to know:

Yes I've released a fix, pull request mentioning this issue will be up shortly