EventStore / EventStore.JVM

Event Store JVM Client
https://geteventstore.com
BSD 3-Clause "New" or "Revised" License
223 stars 40 forks source link

Regarding subscription termination #6

Closed dm3 closed 10 years ago

dm3 commented 10 years ago

Is it safe to assume that a subscription can be terminated by sending a Kill to an actor?

More generally, are there any supervision trees which will appear in the client (e.g. something that will restart the subscription when it's killed)?

t3hnar commented 10 years ago

Hi @dm3, you are asking very nice questions. You should assume that. But this doesn't work yet this way in 0.1

The idea is that ConnectionActor will monitor SubscriptionActor and stop subscription when actor stopped This is a kind of corner case: to have post stop call for SubscriptionActors only.

t3hnar commented 10 years ago

Unsubscribing if actor terminated has been implemented in dev branch

gregoryyoung commented 10 years ago

This should not be implemented on christmas... I demand a refusal of pull request :)

On Wednesday, December 25, 2013, Yaroslav Klymko wrote:

Unsubscribing if actor terminated has been implemented in dev branch

— Reply to this email directly or view it on GitHubhttps://github.com/EventStore/eventstorejvmclient/issues/6#issuecomment-31204166 .

Le doute n'est pas une condition agréable, mais la certitude est absurde.

t3hnar commented 10 years ago

Christmas in UA will be celebrated after New Year, thus this commit doesn't violate law :)

t3hnar commented 10 years ago

fixed