search

EventStore / EventStore.UI

The user interface for Event Store
Other
58 stars 38 forks source link

Upgrade NodeJS to v18.12.1 LTS, bump gulp to v4, replace node-sass with sass #338

Closed 321zer0 closed 1 year ago

321zer0 commented 1 year ago

Upgrade NodeJS from v10.20.1 to v18.12.1 LTS, bump gulp from v3.9.1 to v4.0.0, and replace node-sass (which is now deprecated) with sass. bower has also been updated to v1.8.14 which patches the arbitrary file write security vulnerability, and GitHub Actions workflows have been updated to use Ubuntu 22.04 instead of Ubuntu 18.04.

321zer0 commented 1 year ago

CI Build is failing because GitHub Actions is using node v10.24.1 instead of v18.12.1.

thefringeninja commented 1 year ago

You'll have to go through all the workflow files and update the node version to use.

321zer0 commented 1 year ago

@thefringeninja Workflow files have been updated. I've also updated gulpfile.js to accommodate the breaking changes in gulp v4.0.0 which was causing the CI build to fail.

321zer0 commented 1 year ago

@thefringeninja I've updated the actions to v3. Also bumped bower to v1.8.14 which patches an arbitrary file write security vulnerability: https://snyk.io/blog/severe-security-vulnerability-in-bowers-zip-archive-extraction/

321zer0 commented 1 year ago

@hayley-jean I've updated the setup instructions in the README to use NodeJS v18.12.1. I also tested the setup on a Linux distro and all the gulp commands worked well; I didn't have to install the iconv-lite package. Which version of npm are you using? Can you try with npm v9.2.0?