search

EventStore / EventStoreDB-Client-Java

Official Asynchronous Java 8+ Client Library for EventStoreDB 20.6+
https://eventstore.com
Apache License 2.0
63 stars 20 forks source link

Apply Deadline RFC #142

Closed YoEight closed 2 years ago

oskardudycz commented 2 years ago

I think that it's worth adding some tests to make sure that timeouts are correctly applied on the gRPC channels/connection, etc.

YoEight commented 2 years ago

I fail to see the value behind it, to be honest. For some reason, the Java gRPC lib decided to have an async method for closing a channel. I also feel I would test the internal gRPC client implementation too.

oskardudycz commented 2 years ago

I fail to see the value behind it, to be honest. For some reason, the Java gRPC lib decided to have an async method for closing a channel. I also feel I would test the internal gRPC client implementation too.

I think that we at least need to find repeatable proof in tests that those settings are applied as in the written RFC. I know that it may be non-trivial to have on the integration tests, but maybe there is a way to test it accordingly a least as the removed timeout builder tests.

YoEight commented 2 years ago

Added a couple of extra deadline tests