search

EventStore / EventStoreDB-Client-Java

Official Asynchronous Java 8+ Client Library for EventStoreDB 20.6+
https://eventstore.com
Apache License 2.0
63 stars 20 forks source link

Complete Shutdown messages after drain. #154

Closed dpasek-senacor closed 2 years ago

dpasek-senacor commented 2 years ago

Fixed: Fix Shutdown request completion if connection attempts fail

Bugfix for https://github.com/EventStore/EventStoreDB-Client-Java/issues/153

dpasek-senacor commented 2 years ago

HI @YoEight ! Any ideas why the test case under 20.10.5 fails?

2022-06-13T13:02:05.351+0000 [DEBUG] [TestEventLogger] PersistentSubscriptionManagementTests > testReplayParkedMessages() FAILED
2022-06-13T13:02:05.351+0000 [DEBUG] [TestEventLogger]     java.util.concurrent.TimeoutException
2022-06-13T13:02:05.351+0000 [DEBUG] [TestEventLogger]         at java.util.concurrent.CompletableFuture.timedGet(CompletableFuture.java:1784)
2022-06-13T13:02:05.351+0000 [DEBUG] [TestEventLogger]         at java.util.concurrent.CompletableFuture.get(CompletableFuture.java:1928)
2022-06-13T13:02:05.351+0000 [DEBUG] [TestEventLogger]         at com.eventstore.dbclient.PersistentSubscriptionManagementTests.testReplayParkedMessages(PersistentSubscriptionManagementTests.java:237)

This test shouldn't be affected by the change of this PR but fails now due to timeout, i.e. completion conditions are not reached but only on ES 20.10.5. 🤔 Locally I run the test with 20.10.14 and it does not fail.

YoEight commented 2 years ago

@dpasek-senacor no worries, it's a flakey test, only when running in GHA at least. Hence why I restarted it multiple times to get it green.

YoEight commented 2 years ago

@dpasek-senacor Thanks for your contribution!