search

EventStore / EventStoreDB-Client-Java

Official Asynchronous Java 8+ Client Library for EventStoreDB 20.6+
https://eventstore.com
Apache License 2.0
63 stars 19 forks source link

Inconsistent behaviour of EventSToreDBClient.tombstoneStream() depending on which variant is called (4.0.0 client) #201

Closed thomdreilly closed 1 year ago

thomdreilly commented 1 year ago

The single-argument variant of tombstoneStream and the multiple-argument variant behave differently, as the softDelete flag is set to true in the former case, and false in the latter.

https://github.com/EventStore/EventStoreDB-Client-Java/blob/2189f6bd17289b40fad8784ece2b2e75512750f2/db-client-java/src/main/java/com/eventstore/dbclient/EventStoreDBClient.java#L340

I believe this line has a typo and should actually be: return this.tombstoneStream(streamName, DeleteStreamOptions.get());

YoEight commented 1 year ago

@thomdreilly Thanks for opening the issue and nice catch!